Fix an issue with the previous commit.

Author: c-lipka

changes.txt

@@ -248,6 +248,7 @@ Coverity Scan defects targeted deliberately:
 - CID 1373651: Logically dead code
 - CID 1373652: Dereference before null check
 - CID 1373653: Write to pointer after free
+- CID 1373654: Use after free
 
 Coverity Scan defects eliminated in passing:
 

source/parser/parser_expressions.cpp

@@ -3620,6 +3620,7 @@ GenericSpline *Parser::Parse_Spline()
 {
     GenericSpline * Old = NULL;
     GenericSpline * New = NULL;
+    bool keepOld = false;
     int i = 0;
     EXPRESS Express;
     int Terms, MaxTerms;
@@ -3635,6 +3636,7 @@ GenericSpline *Parser::Parse_Spline()
             Old = reinterpret_cast<GenericSpline *>(Token.Data);
             i = Old->SplineEntries.size();
             MaxTerms = Old->Terms;
+            keepOld = true;
             EXIT
         END_CASE
 
@@ -3647,43 +3649,47 @@ GenericSpline *Parser::Parse_Spline()
     /* Determine kind of spline */
     EXPECT
         CASE(LINEAR_SPLINE_TOKEN)
-            if (New)
-                delete New;
             if (Old)
                 New = new LinearSpline(*Old);
             else
                 New = new LinearSpline();
+            if (Old && !keepOld)
+                delete Old;
             Old = New;
+            keepOld = false;
         END_CASE
 
         CASE(QUADRATIC_SPLINE_TOKEN)
-            if (New)
-                delete New;
             if (Old)
                 New = new QuadraticSpline(*Old);
             else
                 New = new QuadraticSpline();
+            if (Old && !keepOld)
+                delete Old;
             Old = New;
+            keepOld = false;
         END_CASE
 
         CASE(CUBIC_SPLINE_TOKEN)
-            if (New)
-                delete New;
             if (Old)
                 New = new CatmullRomSpline(*Old);
             else
                 New = new CatmullRomSpline();
+            if (Old && !keepOld)
+                delete Old;
             Old = New;
+            keepOld = false;
         END_CASE
 
         CASE(NATURAL_SPLINE_TOKEN)
-            if (New)
-                delete New;
             if (Old)
                 New = new NaturalSpline(*Old);
             else
                 New = new NaturalSpline();
+            if (Old && !keepOld)
+                delete Old;
             Old = New;
+            keepOld = false;
         END_CASE
 
         OTHERWISE