Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[improvement] Run tests automatically for pull requests #256

Open
nolbuzanis opened this issue Apr 7, 2022 · 0 comments
Open

[improvement] Run tests automatically for pull requests #256

nolbuzanis opened this issue Apr 7, 2022 · 0 comments
Labels
enhancement New feature or request future Future implementation without date

Comments

@nolbuzanis
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Not really just good practice. There are lots of tests, but not an easy way to tell if new commits break anything.

Describe the solution you'd like
Could add valid twitter credentials for a test account to the CI pipeline for running tests. Could also change most of these tests to mock the network request if that is not the main function/system under test.
@alkihis alkihis added enhancement New feature or request future Future implementation without date labels Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request future Future implementation without date
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nolbuzanis @alkihis