Skip to content

refactor(cfc): Serializer API #967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 25 commits into from
Nov 3, 2023
Merged

refactor(cfc): Serializer API #967

merged 25 commits into from
Nov 3, 2023

Conversation

volsa
Copy link
Member

@volsa volsa commented Sep 12, 2023

image

@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Attention: 59 lines in your changes are missing coverage. Please review.

Comparison is base (ec4b34c) 95.75% compared to head (1d5df7f) 95.68%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #967      +/-   ##
==========================================
- Coverage   95.75%   95.68%   -0.07%     
==========================================
  Files         153      153              
  Lines       42413    42301     -112     
==========================================
- Hits        40611    40475     -136     
- Misses       1802     1826      +24     
Files Coverage Δ
compiler/plc_driver/src/runner.rs 100.00% <100.00%> (ø)
compiler/plc_xml/src/lib.rs 100.00% <ø> (ø)
compiler/plc_xml/src/model/block.rs 97.43% <100.00%> (+2.19%) ⬆️
compiler/plc_xml/src/model/control.rs 94.44% <100.00%> (+2.33%) ⬆️
compiler/plc_xml/src/model/fbd.rs 99.09% <100.00%> (-0.05%) ⬇️
compiler/plc_xml/src/model/interface.rs 90.00% <100.00%> (-5.00%) ⬇️
compiler/plc_xml/src/xml_parser/control.rs 98.97% <100.00%> (-0.63%) ⬇️
compiler/plc_xml/src/xml_parser/pou.rs 85.71% <100.00%> (ø)
compiler/plc_xml/src/model/connector.rs 87.50% <91.66%> (+1.29%) ⬆️
compiler/plc_xml/src/model/variables.rs 80.55% <98.24%> (+2.62%) ⬆️
... and 11 more

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@volsa volsa mentioned this pull request Oct 4, 2023
@volsa volsa marked this pull request as ready for review October 4, 2023 09:30
@volsa volsa requested review from mhasel, ghaith and riederm October 4, 2023 09:30
ghaith
ghaith previously approved these changes Oct 4, 2023
@volsa volsa requested a review from ghaith October 10, 2023 08:34
Copy link
Member

@mhasel mhasel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Some very minor comments.
Also, the demo.st.out file seems to have snuck into your commits :)

@volsa volsa requested a review from mhasel November 3, 2023 09:33
@volsa volsa merged commit c9e0ed8 into master Nov 3, 2023
@volsa volsa deleted the __serializer branch November 3, 2023 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants