-
Notifications
You must be signed in to change notification settings - Fork 60
fix: add target datalayout and triple to IR #1472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
663c2cd
to
a0d9db6
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1472 +/- ##
==========================================
+ Coverage 93.67% 94.11% +0.44%
==========================================
Files 166 174 +8
Lines 50097 56771 +6674
==========================================
+ Hits 46928 53430 +6502
- Misses 3169 3341 +172 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
volsa
approved these changes
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds target data-layout and target triple to generated IR. This ensures consistent alignment for both generated code and debug information.
This commit changes ALL codegen snapshots. It also removes the previously added special handling for struct debug types since we can now rely on the preferred alignment of LLVM.
Codegen snapshots are now asserted via a wrapper macro over
insta::assert_snapshot
, in which settings for insta are adjusted to filter out thedatalayout
andtarget triple
, since otherwise the CI would fail for windows.