fix(codegen): Convert pointer to actual type when passing by-value

[volsa]

Resolves #1037

We were missing an edge-case where an argument is passed into a function A by-ref (INOUT) which in turn is passed into a function B by-val (INPUT) which generated the following IR for a DINT array

%call = call i32 @function1(i32 %load_x)` // we want `@function1([5 x i32] %load_x)` however

This PR fixes it, in that the commented IR is generated - specifically before passing the argument into function B it is bitcast into its actual type.

---

(A minimal example to reproduce on master)

TYPE mytype : ARRAY [0..2] of DWORD; END_TYPE

FUNCTION main : DINT
    VAR
        arr : mytype;
    END_VAR

	function1(arr);
END_FUNCTION

FUNCTION function1 : DINT
    VAR_IN_OUT
        val   : mytype;
    END_VAR

    function2(val);
END_FUNCTION

FUNCTION function2 : DINT
    VAR_INPUT
        stat : mytype;
    END_VAR
END_FUNCTION

[codecov]

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (cf34cf6) 95.71% compared to head (4dcc25b) 95.73%.
Report is 1 commits behind head on master.

Files	Patch %	Lines
src/codegen/generators/expression_generator.rs	88.57%	4 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1039      +/-   ##
==========================================
+ Coverage   95.71%   95.73%   +0.02%     
==========================================
  Files         153      153              
  Lines       42715    42883     +168     
==========================================
+ Hits        40883    41054     +171     
+ Misses       1832     1829       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mhasel]

Nice find!