Skip to content

Conversation

@oleibman
Copy link
Collaborator

In Theme, change COLOR_SCHEME_2013_PLUS_NAME to private (use COLOR_SCHEME_2013_2022_NAME instead), and delete COLOR_SCHEME_2013_PLUS (use COLOR_SCHEME_2013_2022).

This is:

  • a bugfix
  • a new feature
  • refactoring
  • additional unit tests
  • cleanup for new major release

Checklist:

  • Changes are covered by unit tests
    • Changes are covered by existing unit tests
    • New unit tests have been added
  • Code style is respected
  • Commit message explains why the change is made (see https://github.com/erlang/otp/wiki/Writing-good-commit-messages)
  • CHANGELOG.md contains a short summary of the change and a link to the pull request if applicable
  • Documentation is updated as necessary

In Theme, change COLOR_SCHEME_2013_PLUS_NAME to private (use COLOR_SCHEME_2013_2022_NAME instead), and delete COLOR_SCHEME_2013_PLUS (use COLOR_SCHEME_2013_2022).
@oleibman
Copy link
Collaborator Author

Scrutinizer failed setting up its test. No idea why. Don't really care.

@oleibman oleibman enabled auto-merge August 3, 2025 02:08
@oleibman oleibman added this pull request to the merge queue Aug 3, 2025
Merged via the queue into PHPOffice:master with commit b726eb3 Aug 3, 2025
13 of 14 checks passed
@oleibman oleibman deleted the deprecations branch August 3, 2025 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant