Fix: Missing support for exotic names of excel-workbooks like "workbook2.xml" #1183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 2, 2019 14:41
…ook2.xml", which are fine for excel (cherry picked from commit 1572e40)
… workbook names like "workbook2.xml", which are fine for excel"
rdoering
changed the title
|
Please write, if you have a question. |
|
Is here any progress? |
|
Hay, when will it be merged? I would like to use it as soon as possible! |
|
Travis is only failing on PHP 7.4. |
|
Any news here? |
|
Is the addressed issue aleady fixed? |
|
Yes, thanks to you. I merged your PR, with small adjustments, in 6a2e0ce |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is:
Checklist:
Why this change is needed?
Some auto generated xlsx files are using other names as workbook than "workbook.xml". This is fixed by supporting names of workbooks by regex
/workbook.*\.xml/.