Mrand of zero to any multiple should return 0 (#1773)

martinssipenko · web-flow · commit ec51b75fee62 · 2021-01-07T12:06:26.000+01:00
diff --git a/src/PhpSpreadsheet/Calculation/MathTrig.php b/src/PhpSpreadsheet/Calculation/MathTrig.php
@@ -851,7 +851,7 @@ public static function MROUND($number, $multiple)
         $multiple = Functions::flattenSingleValue($multiple);
 
         if ((is_numeric($number)) && (is_numeric($multiple))) {
-            if ($multiple == 0) {
+            if ($number == 0 || $multiple == 0) {
                 return 0;
             }
             if ((self::SIGN($number)) == (self::SIGN($multiple))) {
diff --git a/tests/data/Calculation/MathTrig/MROUND.php b/tests/data/Calculation/MathTrig/MROUND.php
@@ -41,6 +41,11 @@
         31415.92654,
         1,
     ],
+    [
+        0,
+        0,
+        5,
+    ],
     [
         '#NUM!',
         5,

Original file line number	Diff line number	Diff line change
`@@ -851,7 +851,7 @@ public static function MROUND($number, $multiple)`
`851`	`851`	`$multiple = Functions::flattenSingleValue($multiple);`
`852`	`852`
`853`	`853`	`if ((is_numeric($number)) && (is_numeric($multiple))) {`
`854`		`- if ($multiple == 0) {`
	`854`	`+ if ($number == 0 \|\| $multiple == 0) {`
`855`	`855`	`return 0;`
`856`	`856`	`}`
`857`	`857`	`if ((self::SIGN($number)) == (self::SIGN($multiple))) {`
-Original file line number
+Diff line change
 .92654,
 ,
     ],
 +    [
 +        0,
 +        0,
 +        5,
 +    ],
+    [
         '#NUM!',
 ,