fix: do not trigger Undefined array key "x"

karrakoliko · karrakoliko · commit 4857276f42b7 · 2025-10-01T15:36:51.000+07:00
diff --git a/src/PhpSpreadsheet/Reader/Xml/Style.php b/src/PhpSpreadsheet/Reader/Xml/Style.php
@@ -76,7 +76,7 @@ public function parseStyles(SimpleXMLElement $xml, array $namespaces): array
                         break;
                     case 'Protection':
                         $locked = $hidden = null;
-                        $styleAttributesP = $styleData->attributes($namespaces['x']);
+                        $styleAttributesP = array_key_exists('x',$namespaces) ? $styleData->attributes($namespaces['x']) : [];
                         if (isset($styleAttributes['Protected'])) {
                             $locked = ((bool) (string) $styleAttributes['Protected']) ? Protection::PROTECTION_PROTECTED : Protection::PROTECTION_UNPROTECTED;
                         }

Original file line number	Diff line number	Diff line change
`@@ -76,7 +76,7 @@ public function parseStyles(SimpleXMLElement $xml, array $namespaces): array`
`76`	`76`	`break;`
`77`	`77`	`case 'Protection':`
`78`	`78`	`$locked = $hidden = null;`
`79`		`- $styleAttributesP = $styleData->attributes($namespaces['x']);`
	`79`	`+ $styleAttributesP = array_key_exists('x',$namespaces) ? $styleData->attributes($namespaces['x']) : [];`
`80`	`80`	`if (isset($styleAttributes['Protected'])) {`
`81`	`81`	`$locked = ((bool) (string) $styleAttributes['Protected']) ? Protection::PROTECTION_PROTECTED : Protection::PROTECTION_UNPROTECTED;`
`82`	`82`	`}`