Skip to content

Commit 1fcfadc

Browse files
authored
Fix Unintential Deprecated Calls - Everything Else (#3183)
* Fix Unintential Deprecated Calls - Everything Else I think it's best to install these before PR #3166. This one, which I hope to be the last in this series, does have some minor changes to source code, as well as to doc-blocks and to test members which continue to inadvertently use calls to deprecated functions. * Some Remaining Deprecations in Tests Fix them now. * Minor Docblock Updates Worksheet::unprotectCellsByColumnAndRow was incorrect. Other changes are cosmetic, leading to slightly better documentation. * Update Worksheet.php
1 parent 51a1d6e commit 1fcfadc

File tree

20 files changed

+677
-505
lines changed

20 files changed

+677
-505
lines changed

phpstan-baseline.neon

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -640,10 +640,6 @@ parameters:
640640
message: "#^Cannot call method getNamespaces\\(\\) on SimpleXMLElement\\|false\\.$#"
641641
count: 1
642642
path: src/PhpSpreadsheet/Reader/Ods.php
643-
-
644-
message: "#^Cannot call method setSelectedCellByColumnAndRow\\(\\) on PhpOffice\\\\PhpSpreadsheet\\\\Worksheet\\\\Worksheet\\|null\\.$#"
645-
count: 1
646-
path: src/PhpSpreadsheet/Reader/Ods.php
647643
-
648644
message: "#^Method PhpOffice\\\\PhpSpreadsheet\\\\Reader\\\\Ods\\:\\:listWorksheetNames\\(\\) should return array\\<string\\> but returns array\\<int, string\\|null\\>\\.$#"
649645
count: 1

samples/Chart/33_Chart_create_line_dateaxis.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -358,7 +358,7 @@ function dateRange(int $nrows, Spreadsheet $wrkbk): array
358358
$ExcelQtrStartDateVal = SharedDate::convertIsoDate($qtrStartStr);
359359

360360
// end the xaxis at the end of the quarter of the last date
361-
$lastDateStr = $dataSheet->getCellByColumnAndRow(2, $nrows + 1)->getValue();
361+
$lastDateStr = $dataSheet->getCell([2, $nrows + 1])->getValue();
362362
$lastDate = DateTime::createFromFormat('Y-m-d', $lastDateStr);
363363
$lastMonth = (int) $lastDate->format('n');
364364
$lastYr = (int) $lastDate->format('Y');

0 commit comments

Comments
 (0)