Add missing setters for pageSizeW and pageSizeH #379
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@spikex Could you add some unit tests before merging ? |
Contributor
Author
|
Tests added! |
Member
|
@spikex Could you ask you some documentation and it will be perfect :) ? |
Contributor
Author
|
I've updated the docs. |
Progi1984
added a commit
that referenced
this pull request
Oct 2, 2014
Add missing setters for pageSizeW and pageSizeH
Member
|
@spikex Could you point your PR to the develop branch, please ? And add your work in Changelog.md ? |
Contributor
Author
|
Can I change it now that it's merged? |
Member
|
I have reverted it the PR. |
Contributor
Author
|
Hmm, I'm still seeing it as merged. Do you need to do it as a new PR? |
Member
|
I have done a revert (8ebe3b3). Yes, i need it as a new PR. Sorry. |
Contributor
Author
|
No worries. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #336