Merge pull request #185 from PHPJasper/develop

update: tests, add: phpcs.xml

Author: geekcom

.gitignore

@@ -1,7 +1,8 @@
 /vendor
 tests/*.jasper
 tests/fixture
-tests/codeCoverage
+/tests/logs
+.phpcs-cache
 
 # IDE
 ## Eclipse

phpcs.xml

@@ -0,0 +1,16 @@
+<?xml version="1.0"?>
+<ruleset>
+    <arg name="basepath" value="."/>
+    <arg name="extensions" value="php"/>
+    <arg name="parallel" value="80"/>
+    <arg name="cache" value=".phpcs-cache"/>
+    <arg name="colors"/>
+
+    <arg value="p"/>
+
+    <exclude-pattern type="relative">^/tests/*</exclude-pattern>
+
+    <file>src</file>
+
+    <rule ref="PSR12"/>
+</ruleset>

phpunit.xml

@@ -17,13 +17,14 @@
     </filter>
 
     <testsuites>
-        <testsuite name="Test Suite">
+        <testsuite name="PHPJasper Test Suite">
             <directory>tests</directory>
         </testsuite>
     </testsuites>
 
     <logging>
-        <log type="coverage-html" target="tests/codeCoverage/html"
+        <log type="coverage-html" target="tests/logs/coverage"
              lowUpperBound="50"  highLowerBound="80" charset="UTF-8"/>
+        <log type="testdox-html" target="tests/logs/testdox/testdox.html"/>
     </logging>
 </phpunit>

tests/PHPJasperTest.php

@@ -16,6 +16,7 @@
 use PHPUnit\Framework\TestCase;
 use PHPJasper\PHPJasper;
 use PHPJasper\Exception;
+use ReflectionObject;
 
 /**
  * @author Rafael Queiroz <rafaelfqf@gmail.com>
@@ -34,30 +35,35 @@ public function tearDown()
         unset($this->instance);
     }
 
-    public function testConstructor()
+    /** @test */
+    public function constructor()
     {
         $this->assertInstanceOf(PHPJasper::class, new PHPJasper());
     }
 
-    public function testCompile()
+    /** @test */
+    public function compile()
     {
         $result = $this->instance->compile('examples/hello_world.jrxml', '{output_file}');
 
         $expected = '.*jasperstarter compile ".*hello_world.jrxml" -o "{output_file}"';
 
-        $this->expectOutputRegex('/'.$expected.'/', $result->output());
+        $this->expectOutputRegex('/' . $expected . '/', $result->output());
     }
 
-    public function testProcess()
+
+    /** @test */
+    public function process()
     {
         $result = $this->instance->process('examples/hello_world.jrxml', '{output_file}');
 
         $expected = '.*jasperstarter process ".*hello_world.jrxml" -o "{output_file}"';
 
-        $this->expectOutputRegex('/'.$expected.'/', $result->output());
+        $this->expectOutputRegex('/' . $expected . '/', $result->output());
     }
 
-    public function testProcessWithOptions()
+    /** @test */
+    public function processWithOptions()
     {
         $options = [
             'locale' => 'en_US',
@@ -79,37 +85,35 @@ public function testProcessWithOptions()
         $expected = '.*jasperstarter --locale en_US process ".*hello_world.jrxml" -o "{output_file}" ';
         $expected .= '-f pdf -P  param_1="value_1"   param_2="value_2"   -t driver -u user -p 12345678 -n db -r foo';
 
-        $this->expectOutputRegex(
-            '/'.$expected.'/',
-            $result->output()
-        );
+        $this->expectOutputRegex('/' . $expected . '/', $result->output());
     }
 
-    public function testListParameters()
+    /** @test */
+    public function listParameters()
     {
         $result = $this->instance->listParameters('examples/hello_world.jrxml');
 
-        $this->expectOutputRegex(
-            '/.*jasperstarter list_parameters ".*hello_world.jrxml"/',
-            $result->output()
-        );
+        $this->expectOutputRegex('/.*jasperstarter list_parameters ".*hello_world.jrxml"/', $result->output());
     }
 
-    public function testCompileWithWrongInput()
+    /** @test */
+    public function compileWithWrongInput()
     {
         $this->expectException(Exception\InvalidInputFile::class);
 
         $this->instance->compile('');
     }
 
-    public function testCompileHelloWorld()
+    /** @test */
+    public function compileHelloWorld()
     {
         $result = $this->instance->compile('examples/hello_world.jrxml');
 
         $this->expectOutputRegex('/.*jasperstarter compile ".*hello_world.jrxml"/', $result->output());
     }
 
-    public function testOutputWithUserOnExecute()
+    /** @test */
+    public function outputWithUserOnExecute()
     {
         $this->expectException(Exception\ErrorCommandExecutable::class);
 
@@ -120,37 +124,42 @@ public function testOutputWithUserOnExecute()
         $this->expectOutputRegex('/' . $expected . '/', $this->instance->output());
     }
 
-    public function testExecuteWithoutCompile()
+    /** @test */
+    public function executeWithoutCompile()
     {
         $this->expectException(Exception\InvalidCommandExecutable::class);
 
         $this->instance->execute();
     }
 
-    public function testInvalidInputFile()
+    /** @test */
+    public function invalidInputFile()
     {
         $this->expectException(Exception\InvalidInputFile::class);
 
         $this->instance->compile('{invalid}')->execute();
     }
 
-    public function testExecute()
+    /** @test */
+    public function execute()
     {
         $actual = $this->instance->compile(__DIR__ . '/test.jrxml')->execute();
 
         $this->assertInternalType('array', $actual);
     }
 
-    public function testExecuteWithOutput()
+    /** @test */
+    public function executeWithOutput()
     {
         $actual = $this->instance->compile(__DIR__ . '/test.jrxml', __DIR__ . '/test')->execute();
 
         $this->assertInternalType('array', $actual);
     }
 
-    public function testExecuteThrowsInvalidResourceDirectory()
+    /** @test */
+    public function executeThrowsInvalidResourceDirectory()
     {
-        $reflectionObject = new \ReflectionObject($this->instance);
+        $reflectionObject = new ReflectionObject($this->instance);
         $reflectionProperty = $reflectionObject->getProperty('pathExecutable');
         $reflectionProperty->setAccessible(true);
         $reflectionProperty->setValue($this->instance, '');
@@ -160,28 +169,39 @@ public function testExecuteThrowsInvalidResourceDirectory()
         $this->instance->compile(__DIR__ . '/test.jrxml', __DIR__ . '/test')->execute();
     }
 
-    public function testListParametersWithWrongInput()
+    /** @test */
+    public function listParametersWithWrongInput()
     {
         $this->expectException(Exception\InvalidInputFile::class);
 
         $this->instance->listParameters('');
     }
 
-    public function testProcessWithWrongInput()
+    /** @test */
+    public function processWithWrongInput()
     {
         $this->expectException(Exception\InvalidInputFile::class);
 
-        $this->instance->process('', '', [
-            'format' => 'mp3'
-        ]);
+        $this->instance->process(
+            '',
+            '',
+            [
+                'format' => 'mp3'
+            ]
+        );
     }
 
-    public function testProcessWithWrongFormat()
+    /** @test */
+    public function processWithWrongFormat()
     {
         $this->expectException(Exception\InvalidFormat::class);
 
-        $this->instance->process('hello_world.jrxml', '', [
-            'format' => 'mp3'
-        ]);
+        $this->instance->process(
+            'hello_world.jrxml',
+            '',
+            [
+                'format' => 'mp3'
+            ]
+        );
     }
 }