Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: PHPCSStandards/composer-installer
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: PHPCSStandards/composer-installer
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: TEMP/testing
Choose a head ref
  • 6 commits
  • 10 files changed
  • 1 contributor

Commits on Jun 25, 2022

  1. TEMP/TESTING

    @jrfnl
    jrfnl committed Jun 25, 2022
    Configuration menu
    Copy the full SHA
    7ba30cc View commit details
    Browse the repository at this point in the history

  2. TEMP/focus on quicktest for now

    @jrfnl
    jrfnl committed Jun 25, 2022
    Configuration menu
    Copy the full SHA
    58423eb View commit details
    Browse the repository at this point in the history

  3. TestCase::executeCliCommand(): use non-blocking streams on Windows 

    If an exception is thrown (for whatever reason) in the subprocess, Windows has a tendency to hang on the test.

Let's hope that using non-blocking mode fixes/prevents that.

Note: using non-blocking in combination with Linux actually causes the tests to hang, so applying this for Windows only.
    @jrfnl
    jrfnl committed Jun 25, 2022
    Configuration menu
    Copy the full SHA
    6cd8964 View commit details
    Browse the repository at this point in the history

  4. TEMP/let's check out 5.5 in quicktest

    @jrfnl
    jrfnl committed Jun 25, 2022
    Configuration menu
    Copy the full SHA
    2211f28 View commit details
    Browse the repository at this point in the history

  5. Revert "TEMP/focus on quicktest for now" 

    This reverts commit e27c7c5.
    @jrfnl
    jrfnl committed Jun 25, 2022
    Configuration menu
    Copy the full SHA
    e8abb7e View commit details
    Browse the repository at this point in the history

  6. RegisterExternalStandardsTest: add test registering standard with rul… 

    …eset in package root

* As the behaviour shouldn't be different between Composer local/global, the test is only run against one of these (local).
* The test is run against one random PHPCS version as with the other tests in place, sufficient PHPCS versions are being tested.
    Even though this means there is only _one_ test case, I've elected to still use a data provider to ensure that failing tests will mention the PHPCS version in the test name, which should help with debugging.

Includes adding a fake standard as a fixture for this test.
    @jrfnl
    jrfnl committed Jun 25, 2022
    Configuration menu
    Copy the full SHA
    48d0112 View commit details
    Browse the repository at this point in the history
Loading