Generic/InlineControlStructure: fix error when handling else if
#499
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug in the Generic.ControlStructures.InlineControlStructure sniff where it would not handle correctly
else if
statements when there is a comment between theelse
andif
tokens.The affected code was added in squizlabs/PHP_CodeSniffer@18f98cc to fix a similar bug when there is more than one whitespace between
else
andif
, but it failed to consider that there might be comment tokens betweenelse
andif
.This change was originally part of PR #482, but it was decided to split it into multiple smaller PRs.
Suggested changelog entry
Generic.ControlStructures.InlineControlStructure: properly handle else if statements where there is a comment between else and if
Types of changes
PR checklist