Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: add end-to-end tests for all supported CLI arguments #147

Open
jrfnl opened this issue Dec 9, 2023 · 0 comments
Open

Tests: add end-to-end tests for all supported CLI arguments #147

jrfnl opened this issue Dec 9, 2023 · 0 comments

Comments

@jrfnl
Copy link
Member

jrfnl commented Dec 9, 2023

End to end tests should be introduced in a separate test suite to cover the use of all supported CLI arguments (and some combinations of these).

PHPUnit supports a phpt format to run end to end tests, though there is not much documentation available on writing them (see sebastianbergmann/phpunit-documentation-english#302).
Alternatively, something like the expect could possibly be used.

I've written some tests as a proof of concept and will try to make those publicly available in the near future to serve as an example to expand on.

The end-to-end tests should preferably be run in CI on:

  • Different OSes (Linux, Mac, Windows)
  • A few different PHP versions (high/low supported versions and possible some extra if there are specific issues which need to be tested on specific versions)
  • Using the PHAR file + using a Composer install
  • With a few different extensions enabled/disabled combinations, including PCNTL and gRPC (see PHP gRPC extension breaks use of --parallel #294).
  • With a few different combinations of relevant ini settings (can likely be configured per test)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant