[Bug-Fix] When shipping address is null (e.g. virtual products) there is an error #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, thanks! |
|
Thanks for your contribution, this fix will be add to the next release 👍 |
|
Great thank you :) Now I can update automatically again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've encountered this on our website when trying to anonymize a user's existing orders. The products are virtual and the user isn't required to fill in his shipping details, therefore the shipping address in this case is null and not an Id. Therefore
$order->getShippingAddress()will return false and there is no handling for this use case.This pull request is a suggestion but maybe you want to implement a more robust check in this scenario.