Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Problem.from_yaml, extract get_path_prefix #280

Merged
merged 3 commits into from
Jun 26, 2024

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Jun 26, 2024

More readable, testable, modular, and will be required in other places soon.

More readable, testable, modular, and will be required in other places soon.
@dweindl dweindl requested a review from a team as a code owner June 26, 2024 19:41
@codecov-commenter
Copy link

codecov-commenter commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.12%. Comparing base (74ac20d) to head (e02d2e9).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #280      +/-   ##
===========================================
+ Coverage    76.09%   76.12%   +0.03%     
===========================================
  Files           36       36              
  Lines         3233     3238       +5     
  Branches       786      785       -1     
===========================================
+ Hits          2460     2465       +5     
  Misses         568      568              
  Partials       205      205              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

petab/yaml.py Outdated Show resolved Hide resolved
dweindl and others added 2 commits June 26, 2024 21:52
Co-authored-by: Dilan Pathirana <59329744+dilpath@users.noreply.github.com>
@dweindl dweindl merged commit 41481bb into PEtab-dev:develop Jun 26, 2024
7 checks passed
@dweindl dweindl deleted the refactor_from_yaml branch June 26, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants