Startpoint sampling for a subset of parameters #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #230 +/- ##
===========================================
+ Coverage 76.24% 76.28% +0.04%
===========================================
Files 34 34
Lines 3182 3188 +6
Branches 773 774 +1
===========================================
+ Hits 2426 2432 +6
Misses 555 555
Partials 201 201
|
Allow passing a list of parameter IDs to startpoint sampling for subsetting/reordering parameters.
dweindl
force-pushed
the
startpoints_by_id
branch
from
db54096 to
a0b6ac0
Compare
plakrisenko
approved these changes
Nov 5, 2023
plakrisenko
reviewed
Nov 5, 2023
petab/parameters.py
Outdated
| # get types and parameters of priors from dataframe | ||
| par_to_estimate = parameter_df.loc[parameter_df[ESTIMATE] == 1] | ||
|
|
||
| if parameter_ids: | ||
| par_to_estimate = par_to_estimate.loc[parameter_ids, :] |
There was a problem hiding this comment.
Maybe add an error message for the case when provided parameter_ids list contains an id that is not there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow passing a list of parameter IDs to startpoint sampling for subsetting/reordering parameters.