Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make validate_visualization_df work without matplotlib installation #215

Merged
merged 2 commits into from
Jul 17, 2023

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Jul 17, 2023

Only import plotting functions in petab.visualize if matplotlib is installed.

Closes #212

Only import plotting functions in `petab.visualize` if matplotlib is installed.

Closes #212
@dweindl dweindl requested a review from plakrisenko as a code owner July 17, 2023 17:56
@dweindl dweindl requested a review from dilpath July 17, 2023 18:02
Copy link
Member

@dilpath dilpath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

petab/visualize/__init__.py Outdated Show resolved Hide resolved
Co-authored-by: Dilan Pathirana <59329744+dilpath@users.noreply.github.com>
@codecov-commenter
Copy link

Codecov Report

Merging #215 (597464e) into develop (25ee7aa) will decrease coverage by 0.01%.
The diff coverage is 85.71%.

@@             Coverage Diff             @@
##           develop     #215      +/-   ##
===========================================
- Coverage    76.32%   76.32%   -0.01%     
===========================================
  Files           34       34              
  Lines         3168     3172       +4     
  Branches       768      769       +1     
===========================================
+ Hits          2418     2421       +3     
  Misses         552      552              
- Partials       198      199       +1     
Impacted Files Coverage Δ
petab/visualize/__init__.py 88.88% <85.71%> (-11.12%) ⬇️

@dweindl dweindl merged commit b02d768 into develop Jul 17, 2023
@dweindl dweindl deleted the fix_212 branch July 17, 2023 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants