Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SBML validation #168

Merged
merged 1 commit into from
Jul 21, 2022
Merged

Fix SBML validation #168

merged 1 commit into from
Jul 21, 2022

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Jul 21, 2022

Fixes #166 (double logging)
Fixes #167 (ignoring severity)

Fixes #166 (double logging)
Fixes #167 (ignoring severity)
@dweindl dweindl requested a review from FFroehlich July 21, 2022 10:09
@codecov-commenter
Copy link

Codecov Report

Merging #168 (c9ab2da) into develop (47362d3) will increase coverage by 0.15%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop     #168      +/-   ##
===========================================
+ Coverage    77.30%   77.45%   +0.15%     
===========================================
  Files           29       29              
  Lines         2578     2573       -5     
  Branches       593      591       -2     
===========================================
  Hits          1993     1993              
+ Misses         430      425       -5     
  Partials       155      155              
Impacted Files Coverage Δ
petab/models/sbml_model.py 94.54% <0.00%> (+3.31%) ⬆️
petab/sbml.py 64.86% <0.00%> (+1.70%) ⬆️

Copy link
Collaborator

@FFroehlich FFroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dweindl dweindl merged commit 82b2f6d into develop Jul 21, 2022
@dweindl dweindl deleted the fix_166_167 branch July 21, 2022 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants