Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More informative petab.calculate errors #151

Merged
merged 3 commits into from
May 24, 2022
Merged

More informative petab.calculate errors #151

merged 3 commits into from
May 24, 2022

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented May 20, 2022

Show which symbols cannot be handled. Closes #29.

Show which symbols cannot be handled. Closes #29.
@dweindl dweindl requested a review from yannikschaelte May 20, 2022 14:28
@dweindl dweindl linked an issue May 20, 2022 that may be closed by this pull request
@dweindl dweindl requested a review from dilpath May 23, 2022 10:45
petab/calculate.py Outdated Show resolved Hide resolved
petab/calculate.py Outdated Show resolved Hide resolved
petab/calculate.py Outdated Show resolved Hide resolved
Co-authored-by: Dilan Pathirana <59329744+dilpath@users.noreply.github.com>
@codecov-commenter
Copy link

codecov-commenter commented May 23, 2022

Codecov Report

Merging #151 (d4679e8) into develop (3c279ea) will decrease coverage by 0.05%.
The diff coverage is 83.33%.

@@             Coverage Diff             @@
##           develop     #151      +/-   ##
===========================================
- Coverage    77.20%   77.14%   -0.06%     
===========================================
  Files           26       26              
  Lines         2443     2437       -6     
  Branches       579      579              
===========================================
- Hits          1886     1880       -6     
  Misses         404      404              
  Partials       153      153              
Impacted Files Coverage Δ
petab/calculate.py 89.84% <83.33%> (-0.46%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c279ea...d4679e8. Read the comment docs.

@dweindl dweindl removed the request for review from yannikschaelte May 23, 2022 11:01
@dweindl dweindl merged commit 7a0b77e into develop May 24, 2022
@dweindl dweindl deleted the calculate_err_msg branch May 24, 2022 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

observables but not species supported in noiseFormula
3 participants