Skip to content

Commit 1583431

Browse files
committed
remove todo
1 parent c15876e commit 1583431

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

petab/v1/math/sympify.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,6 @@
1616
def sympify_petab(expr: str | int | float | sp.Basic) -> sp.Expr | sp.Basic:
1717
"""Convert PEtab math expression to sympy expression.
1818
19-
.. note::
20-
21-
All symbols in the returned expression will have the ``real=True``
22-
assumption.
2319
2420
Args:
2521
expr: PEtab math expression.
@@ -31,6 +27,11 @@ def sympify_petab(expr: str | int | float | sp.Basic) -> sp.Expr | sp.Basic:
3127
Returns:
3228
The sympy expression corresponding to `expr`.
3329
Boolean values are converted to numeric values.
30+
31+
.. note::
32+
33+
All symbols in the returned expression will have the ``real=True``
34+
assumption.
3435
"""
3536
if isinstance(expr, sp.Basic):
3637
return sympify_petab(petab_math_str(expr))

tests/v1/math/test_math.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@ def test_assumptions():
2929
assert sympify_petab("x").is_real
3030

3131
# non-real symbols are changed to real
32-
# TODO: should we raise an error instead?
3332
assert sympify_petab(sp.Symbol("x", real=False)).is_real
3433

3534

0 commit comments

Comments
 (0)