Allow URL as filenames for YAML files and SBML models (Closes #187) #459
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #459 +/- ##
===========================================
+ Coverage 78.02% 78.11% +0.09%
===========================================
Files 22 22
Lines 2225 2244 +19
Branches 531 536 +5
===========================================
+ Hits 1736 1753 +17
- Misses 363 364 +1
- Partials 126 127 +1
Continue to review full report at Codecov.
|
| else: | ||
| buffer = ''.join(line for line in buffer) | ||
|
|
||
| # URL or already opened file, we will load the model from a string |
There was a problem hiding this comment.
how do you know the file is opened already?
There was a problem hiding this comment.
From if is_file_like(filepath_or_buffer) or is_url(filepath_or_buffer): above. the former checks exactly that.
There was a problem hiding this comment.
(and the latter would return a generator yielding the remote file content)
| yaml_url = "https://raw.githubusercontent.com/PEtab-dev/petab_test_suite" \ | ||
| "/master/cases/0001/_0001.yaml" | ||
| petab_problem = petab.Problem.from_yaml(yaml_url) | ||
|
|
There was a problem hiding this comment.
can e.g. also check nr of data / parameters, ... to see it is actually what is expected
There was a problem hiding this comment.
Can, but I wouldn't find it too helpful. What would be a realistic scenario that would be covered by that? Keep it simple? :)
Release 0.1.9 Library: * Allow URL as filenames for YAML files and SBML models (Closes #187) (#459) * Allow model time in observable formulas (#445) * Make float parsing from CSV round-trip (#444) * Validator: Error message for missing IDs, with line numbers. (#467) * Validator: Detect duplicated observable IDs (#446) * Some documentation and CI fixes / updates * Visualization: Add option to save visualization specification (#457) * Visualization: Column XValue not mandatory anymore (#429) * Visualization: Add sorting of indices of dataframes for the correct sorting of x-values (#430) * Visualization: Default value for the column x_label in vis_spec (#431)
No description provided.