Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix calculate_llh and calculate_llh #451

Merged
merged 1 commit into from
Jul 21, 2020
Merged

Fix calculate_llh and calculate_llh #451

merged 1 commit into from
Jul 21, 2020

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Jul 19, 2020

don't try to compare missing columns. Closes #450.

don't try to compare missing columns. Closes #450.
@codecov
Copy link

codecov bot commented Jul 19, 2020

Codecov Report

Merging #451 into develop will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #451      +/-   ##
===========================================
+ Coverage    78.00%   78.02%   +0.01%     
===========================================
  Files           22       22              
  Lines         2223     2225       +2     
  Branches       531      531              
===========================================
+ Hits          1734     1736       +2     
  Misses         363      363              
  Partials       126      126              
Impacted Files Coverage Δ
petab/calculate.py 89.47% <100.00%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b031e8...36e7a36. Read the comment docs.

@dweindl dweindl merged commit a5dd618 into develop Jul 21, 2020
@dweindl dweindl deleted the fix_450 branch July 21, 2020 08:52
@yannikschaelte yannikschaelte mentioned this pull request Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants