Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

default value for the column x_label in vis_spec #431

Merged
merged 7 commits into from
Jul 2, 2020
Merged

default value for the column x_label in vis_spec #431

merged 7 commits into from
Jul 2, 2020

Conversation

plakrisenko
Copy link
Member

discussed in #319

@plakrisenko plakrisenko requested a review from erikadudki April 21, 2020 11:56
@codecov
Copy link

codecov bot commented Apr 21, 2020 •
edited
Loading

Codecov Report

Merging #431 into develop will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #431   +/-   ##
========================================
  Coverage    77.99%   78.00%           
========================================
  Files           22       22           
  Lines         2222     2223    +1     
  Branches       531      531           
========================================
+ Hits          1733     1734    +1     
  Misses         363      363           
  Partials       126      126
Impacted Files Coverage Δ
petab/visualize/helper_functions.py 83.44% <100.00%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cbf54e...91ddb10. Read the comment docs.

erikadudki
erikadudki approved these changes Apr 21, 2020
View reviewed changes
Copy link
Contributor

@erikadudki erikadudki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine. This is also somehow addressed in the pull request #429, where I set the XLABEL to the condition name from the condition table, but this can then later be discussed which version we prefer :-)

@plakrisenko
Copy link
Member Author

looks fine. This is also somehow addressed in the pull request #429, where I set the XLABEL to the condition name from the condition table, but this can then later be discussed which version we prefer :-)

I will have a look at your pull-request then!

@yannikschaelte
Copy link
Member

ping @plakrisenko

@dweindl
Copy link
Member

dweindl commented May 30, 2020

ping @plakrisenko

@yannikschaelte yannikschaelte merged commit 4b031e8 into develop Jul 2, 2020
@yannikschaelte yannikschaelte deleted the pl_misc branch July 2, 2020 13:35
@yannikschaelte yannikschaelte mentioned this pull request Jul 23, 2020
Merged
dweindl added a commit that referenced this pull request Sep 21, 2020
@dweindl
Merge pull request #468 from PEtab-dev/release_0.1.9
826e7f7 
Release 0.1.9

Library:

* Allow URL as filenames for YAML files and SBML models (Closes #187) (#459)
* Allow model time in observable formulas (#445)
* Make float parsing from CSV round-trip (#444)
* Validator: Error message for missing IDs, with line numbers. (#467)
* Validator: Detect duplicated observable IDs (#446)
* Some documentation and CI fixes / updates
* Visualization: Add option to save visualization specification (#457)
* Visualization: Column XValue not mandatory anymore (#429)
* Visualization: Add sorting of indices of dataframes for the correct sorting
  of x-values (#430)
* Visualization: Default value for the column x_label in vis_spec (#431)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikadudki erikadudki erikadudki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@plakrisenko @yannikschaelte @dweindl @erikadudki