add sorting of indices of dataframes for the correct sorting of x-values #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y and has to be handled differently
Codecov Report
@@ Coverage Diff @@
## develop #430 +/- ##
===========================================
- Coverage 77.91% 77.88% -0.04%
===========================================
Files 22 22
Lines 2205 2211 +6
Branches 527 529 +2
===========================================
+ Hits 1718 1722 +4
- Misses 362 363 +1
- Partials 125 126 +1
Continue to review full report at Codecov.
|
yannikschaelte
approved these changes
Apr 22, 2020
petab/visualize/plotting_config.py
Outdated
| elif isinstance(conditions, pd.core.series.Series): | ||
| conditions.sort_index(inplace=True) | ||
| else: | ||
| print('strange: conditions object is neither numpy nor ' |
There was a problem hiding this comment.
should this raise an error, i.e. the case never occur? then raise ValueError("Strange: ...")
MerktSimon
approved these changes
Apr 23, 2020
Co-Authored-By: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com>
|
ping @erikadudki |
Merged
dweindl
added a commit
that referenced
this pull request
Sep 21, 2020
Release 0.1.9 Library: * Allow URL as filenames for YAML files and SBML models (Closes #187) (#459) * Allow model time in observable formulas (#445) * Make float parsing from CSV round-trip (#444) * Validator: Error message for missing IDs, with line numbers. (#467) * Validator: Detect duplicated observable IDs (#446) * Some documentation and CI fixes / updates * Visualization: Add option to save visualization specification (#457) * Visualization: Column XValue not mandatory anymore (#429) * Visualization: Add sorting of indices of dataframes for the correct sorting of x-values (#430) * Visualization: Default value for the column x_label in vis_spec (#431)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
conditionsandmshave to coincide, the problem here was, that they weren't. So now, index sorting is performed beforeconditionsandmsare zipped together and then afterwards sorted according to ascending conditions.closes something wrong with the ordering xValues in dose response #414