Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more tests for visualization routine #418

Merged
merged 2 commits into from
Mar 27, 2020
Merged

more tests for visualization routine #418

merged 2 commits into from
Mar 27, 2020

Conversation

MerktSimon
Copy link
Member

activate tests for minimal data file (cf issue #415)
tests without visu file now also with simu data

One might still argue that the minimal visualization file is not minimal since it still has the datasetId column. Imo it is only optional if one provide a dataset, condition or observable list to the function plot_data_and_simulation()
Any opinions on this?

tests without visu file now also with simu data
@MerktSimon MerktSimon requested a review from FFroehlich March 26, 2020 17:52
@codecov
Copy link

codecov bot commented Mar 26, 2020

Codecov Report

Merging #418 into develop will increase coverage by 0.09%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #418      +/-   ##
===========================================
+ Coverage    77.84%   77.93%   +0.09%     
===========================================
  Files           22       22              
  Lines         2126     2126              
  Branches       498      498              
===========================================
+ Hits          1655     1657       +2     
+ Misses         344      343       -1     
+ Partials       127      126       -1
Impacted Files Coverage Δ
petab/visualize/helper_functions.py 88.15% <0%> (ø) ⬆️
petab/visualize/plot_data_and_simulation.py 77.27% <0%> (+3.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9260f0...58f611c. Read the comment docs.

Copy link
Collaborator

@FFroehlich FFroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding tests where the DATASET_ID column are dropped from simdata/expdata shouldn't be too much effort right? Would also add coverage to the respective fill-in function.

@JanHasenauer
Copy link
Contributor

Very good idea! The test would be very useful.

@MerktSimon
Copy link
Member Author

Right now the routine seems still to struggle withouth the datasetId column.
But @plakrisenko is currently working on #272 and #190 including support of this. (https://github.com/PEtab-dev/PEtab/tree/pl_visualization)
I will include the according tests there.

@MerktSimon MerktSimon merged commit b56b092 into develop Mar 27, 2020
@MerktSimon MerktSimon deleted the fix415 branch March 27, 2020 18:05
@yannikschaelte yannikschaelte mentioned this pull request Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants