-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Function to create basic/default yaml file #398
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #398 +/- ##
===========================================
+ Coverage 77.78% 77.88% +0.09%
===========================================
Files 22 22
Lines 2098 2116 +18
Branches 486 493 +7
===========================================
+ Hits 1632 1648 +16
- Misses 343 344 +1
- Partials 123 124 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not so much in favor of adding that, as all those get_default_*_file_name functions are marked for removal.
I agree that this function won't be too useful, since the employed default names are marked for removal already (they originated from back when there was no yaml yet but just standardized file names). What would however make a lot of sense, not sure if it exists yet @dweindl , is the ability for a given petab problem (or rather a collection of file names) to write a yaml file linking all files. |
I agree and vote for not include this |
Yeah, may make sense to extend |
I got rid of all the |
No description provided.