Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visu sorting problem #396

Merged
merged 5 commits into from
Mar 20, 2020
Merged

Visu sorting problem #396

merged 5 commits into from
Mar 20, 2020

Conversation

erikadudki
Copy link
Contributor

  • now Xvalues (conditions) are sorted monotonically increasing

closes #393, closes #330,
(@MerktSimon does this also close #207?)

@erikadudki erikadudki requested a review from MerktSimon March 20, 2020 15:53
@codecov
Copy link

codecov bot commented Mar 20, 2020

Codecov Report

Merging #396 into develop will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #396      +/-   ##
===========================================
+ Coverage    77.77%   77.79%   +0.02%     
===========================================
  Files           22       22              
  Lines         2070     2072       +2     
  Branches       476      476              
===========================================
+ Hits          1610     1612       +2     
  Misses         340      340              
  Partials       120      120
Impacted Files Coverage Δ
petab/visualize/helper_functions.py 88.73% <100%> (+0.05%) ⬆️
petab/visualize/plotting_config.py 48.19% <100%> (+0.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d3119c...23160c9. Read the comment docs.

Copy link
Member

@MerktSimon MerktSimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just remove the two not needed lines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants