Deprecate petab.sbml.globalize_parameters #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #381 +/- ##
===========================================
- Coverage 77.78% 77.74% -0.04%
===========================================
Files 22 22
Lines 2066 2067 +1
Branches 475 475
===========================================
Hits 1607 1607
- Misses 339 340 +1
Partials 120 120
Continue to review full report at Codecov.
|
yannikschaelte
approved these changes
Mar 13, 2020
"It should have never gotten in here"? :) |
exactly :) now it's documented ;) |
Function has nothing to do with PEtab's objectives, and is not usable at the moment. Better functionality is available through libsbml.SBMLLocalParameterConverter. Therefore, this should be removed.
This was referenced Mar 15, 2020
Merged
dweindl
added a commit
that referenced
this pull request
Mar 18, 2020
Release 0.1.5 Library: * New create empty observable function (issue 386) (#387) * Deprecate petab.sbml.globalize_parameters (#381) * Fix computing log10 likelihood (#380) * Documentation update and typehints for visualization (#372) * Ordered result of `petab.get_output_parameters` * Fix missing argument to parameters.create_parameter_df Documentation: * Add overview of supported PEtab feature in toolboxes * Add contribution guide * Fix optional values in documentation (#378)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Function has nothing to do with PEtab's objectives, and is not usable
at the moment. Better functionality is available through
libsbml.SBMLLocalParameterConverter. Therefore, this should be removed.