Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validator: handle undefined observables more gracefully (Closes #300) #351

Merged
merged 3 commits into from
Feb 28, 2020

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Feb 28, 2020

No description provided.

@codecov
Copy link

codecov bot commented Feb 28, 2020

Codecov Report

Merging #351 into develop will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           develop    #351   +/-   ##
=======================================
  Coverage     76.9%   76.9%           
=======================================
  Files           23      23           
  Lines         2018    2018           
  Branches       448     448           
=======================================
  Hits          1552    1552           
  Misses         350     350           
  Partials       116     116
Impacted Files Coverage Δ
petab/lint.py 74.03% <ø> (ø) ⬆️
petab/calculate.py 89.14% <ø> (ø) ⬆️
petab/parameter_mapping.py 72.5% <ø> (ø) ⬆️
petab/parameters.py 90.69% <ø> (ø) ⬆️
petab/measurements.py 83.67% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9eebb90...65bbd53. Read the comment docs.

petab/lint.py Outdated Show resolved Hide resolved
@dweindl dweindl merged commit 5da4527 into develop Feb 28, 2020
@dweindl dweindl deleted the fix_300 branch February 28, 2020 12:14
@dweindl dweindl mentioned this pull request Feb 28, 2020
dweindl added a commit that referenced this pull request Feb 28, 2020
Release 0.1.3

File format:

* Updated documentation
* Observables table in YAML file now mandatory in schema (was implicitly 
  mandatory before, as observable table was required already)

Library:
* petablint:
  * Fix: allow specifying observables file via CLI (Closes #302)
  * Fix: nominalValue is optional unless estimated!=1 anywhere (Fixes #303)
  * Fix: handle undefined observables more gracefully (Closes #300) (#351)
* Parameter mapping: 
  * Fix / refactor parameter mapping (breaking change) (#344)
    (now performing parameter value and scale mapping together)
  * check optional measurement cols in mapping (#350)
* allow calculating llhs (#349), chi2 values (#348) and residuals (#345)
* Visualization
  * Basic Scatterplots & lot of bar plot fixes (#270)
  * Fix incorrect length of bool `bool_preequ` when subsetting with ind_meas 
    (Closes #322)
* make libcombine optional (#338)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants