Fix docs and add residual calculation function #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #345 +/- ##
===========================================
+ Coverage 75.91% 76.14% +0.23%
===========================================
Files 22 23 +1
Lines 1893 1937 +44
Branches 419 428 +9
===========================================
+ Hits 1437 1475 +38
- Misses 350 352 +2
- Partials 106 110 +4
Continue to review full report at Codecov.
|
dweindl
approved these changes
Feb 26, 2020
FFroehlich
reviewed
Feb 26, 2020
| observable_df = pd.DataFrame(data={ | ||
| OBSERVABLE_ID: ['obs_a'], | ||
| OBSERVABLE_FORMULA: ['A'], | ||
| NOISE_FORMULA: [2] |
There was a problem hiding this comment.
maybe add a test with non-numeric noise_formula?
There was a problem hiding this comment.
those are currently not yet supported, just numeric replacements
There was a problem hiding this comment.
addressed in #347
Merged
dweindl
added a commit
that referenced
this pull request
Feb 28, 2020
Release 0.1.3 File format: * Updated documentation * Observables table in YAML file now mandatory in schema (was implicitly mandatory before, as observable table was required already) Library: * petablint: * Fix: allow specifying observables file via CLI (Closes #302) * Fix: nominalValue is optional unless estimated!=1 anywhere (Fixes #303) * Fix: handle undefined observables more gracefully (Closes #300) (#351) * Parameter mapping: * Fix / refactor parameter mapping (breaking change) (#344) (now performing parameter value and scale mapping together) * check optional measurement cols in mapping (#350) * allow calculating llhs (#349), chi2 values (#348) and residuals (#345) * Visualization * Basic Scatterplots & lot of bar plot fixes (#270) * Fix incorrect length of bool `bool_preequ` when subsetting with ind_meas (Closes #322) * make libcombine optional (#338)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.