Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make libcombine optional #338

Merged
merged 2 commits into from
Feb 25, 2020
Merged

make libcombine optional #338

merged 2 commits into from
Feb 25, 2020

Conversation

yannikschaelte
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Feb 25, 2020

Codecov Report

Merging #338 into develop will decrease coverage by 0.14%.
The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #338      +/-   ##
===========================================
- Coverage    76.63%   76.49%   -0.15%     
===========================================
  Files           22       22              
  Lines         1849     1855       +6     
  Branches       411      411              
===========================================
+ Hits          1417     1419       +2     
- Misses         329      333       +4     
  Partials       103      103
Impacted Files Coverage Δ
petab/core.py 83.6% <50%> (-1.27%) ⬇️
petab/problem.py 72.8% <50%> (-0.53%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a41a2f7...5222541. Read the comment docs.

@yannikschaelte yannikschaelte merged commit ffdc8b0 into develop Feb 25, 2020
@yannikschaelte yannikschaelte deleted the feature_libcombine_opt branch February 25, 2020 13:55
@dweindl dweindl mentioned this pull request Feb 28, 2020
dweindl added a commit that referenced this pull request Feb 28, 2020
Release 0.1.3

File format:

* Updated documentation
* Observables table in YAML file now mandatory in schema (was implicitly 
  mandatory before, as observable table was required already)

Library:
* petablint:
  * Fix: allow specifying observables file via CLI (Closes #302)
  * Fix: nominalValue is optional unless estimated!=1 anywhere (Fixes #303)
  * Fix: handle undefined observables more gracefully (Closes #300) (#351)
* Parameter mapping: 
  * Fix / refactor parameter mapping (breaking change) (#344)
    (now performing parameter value and scale mapping together)
  * check optional measurement cols in mapping (#350)
* allow calculating llhs (#349), chi2 values (#348) and residuals (#345)
* Visualization
  * Basic Scatterplots & lot of bar plot fixes (#270)
  * Fix incorrect length of bool `bool_preequ` when subsetting with ind_meas 
    (Closes #322)
* make libcombine optional (#338)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants