Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for petab.measurements.get_simulation_conditions #297

Merged
merged 2 commits into from
Feb 18, 2020
Merged

Add tests for petab.measurements.get_simulation_conditions #297

merged 2 commits into from
Feb 18, 2020

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Feb 17, 2020

No description provided.

@codecov
Copy link

codecov bot commented Feb 17, 2020 •
edited
Loading

Codecov Report

Merging #297 into develop will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #297   +/-   ##
========================================
  Coverage    76.86%   76.86%           
========================================
  Files           22       22           
  Lines         1837     1837           
  Branches       406      406           
========================================
  Hits          1412     1412           
  Misses         324      324           
  Partials       101      101
Impacted Files Coverage Δ
petab/measurements.py 83.5% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 581492d...5136276. Read the comment docs.

yannikschaelte
yannikschaelte approved these changes Feb 17, 2020
View reviewed changes
petab/measurements.py Outdated Show resolved Hide resolved
tests/test_measurements.py Outdated Show resolved Hide resolved
tests/test_measurements.py Outdated Show resolved Hide resolved
tests/test_measurements.py Outdated Show resolved Hide resolved
tests/test_measurements.py Outdated Show resolved Hide resolved
tests/test_measurements.py Show resolved Hide resolved
@dweindl @yannikschaelte
Apply suggestions from code review
5136276 
Co-Authored-By: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com>
@dweindl dweindl merged commit c1e7d66 into develop Feb 18, 2020
@dweindl dweindl deleted the dw_misc branch February 18, 2020 07:01
@yannikschaelte yannikschaelte mentioned this pull request Feb 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yannikschaelte yannikschaelte yannikschaelte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dweindl @yannikschaelte