Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix format documentation regarding parameter scale #289

Merged
merged 2 commits into from
Feb 14, 2020

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Feb 13, 2020

No description provided.

@dweindl dweindl requested a review from fbergmann February 13, 2020 08:35
@codecov
Copy link

codecov bot commented Feb 13, 2020

Codecov Report

Merging #289 into develop will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #289   +/-   ##
========================================
  Coverage    77.18%   77.18%           
========================================
  Files           22       22           
  Lines         1823     1823           
  Branches       398      398           
========================================
  Hits          1407     1407           
  Misses         320      320           
  Partials        96       96           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 023f19e...41cce5b. Read the comment docs.

Copy link
Contributor

@fbergmann fbergmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that works for me, I'm still really, really unhappy, that the new interpretation of parameterScale is incompatible with what we did last year. Last year the meaning was, that if paramterScale was log10, then the corresponding values had to be taken as pow(10, value). You decided to be fine with basically invalidating all implementations from last year.

But that is independent of this commit, this commit is fine and necessary. And it is consistent with the decision you made.

@dweindl
Copy link
Member Author

dweindl commented Feb 14, 2020

Yeah, sorry for breaking things there. Apart from the breaking change, I think it makes life easier in the future though. If one only wants to simulate the model, one can simply ignore the parameter scaling, and it put an end to the confusion with the observable transformation which was handled incoherently.

@dweindl dweindl merged commit 1dc87d9 into develop Feb 14, 2020
@dweindl dweindl deleted the fix_parameter_doc branch February 14, 2020 08:50
@yannikschaelte yannikschaelte mentioned this pull request Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants