Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature defaultvalues #288

Merged
merged 8 commits into from
Feb 11, 2020
Merged

Feature defaultvalues #288

merged 8 commits into from
Feb 11, 2020

Conversation

yannikschaelte
Copy link
Member

  • add normalize function for parameter dfs. in particular fills in priors and prior parameters.

@yannikschaelte yannikschaelte self-assigned this Feb 11, 2020
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (develop@be17124). Click here to learn what that means.
The diff coverage is 86.95%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #288   +/-   ##
==========================================
  Coverage           ?   77.18%           
==========================================
  Files              ?       22           
  Lines              ?     1823           
  Branches           ?      398           
==========================================
  Hits               ?     1407           
  Misses             ?      320           
  Partials           ?       96
Impacted Files Coverage Δ
petab/core.py 84.87% <100%> (ø)
petab/lint.py 74.81% <82.6%> (ø)
petab/parameters.py 94.35% <90.47%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be17124...ed2bc8a. Read the comment docs.

dweindl
dweindl approved these changes Feb 11, 2020
View reviewed changes
petab/parameters.py Outdated
df = parameter_df.copy(deep=True)

if PARAMETER_NAME not in df:
df[PARAMETER_NAME] = None
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe more helpful to set to parameter_ids then?

@yannikschaelte yannikschaelte merged commit 1ba6f5c into develop Feb 11, 2020
@yannikschaelte yannikschaelte deleted the feature_defaultvalues branch February 11, 2020 18:39
@yannikschaelte yannikschaelte mentioned this pull request Feb 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dweindl dweindl Awaiting requested review from dweindl

@erikadudki erikadudki Awaiting requested review from erikadudki

Assignees

@yannikschaelte yannikschaelte

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yannikschaelte @codecov-io @dweindl