Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix prior scales #286

Merged
merged 10 commits into from
Feb 11, 2020
Merged

Fix prior scales #286

merged 10 commits into from
Feb 11, 2020

Conversation

yannikschaelte
Copy link
Member

  • fix get_prior_from_df returning wrong scales if using default bounds
  • fix get_prior_from_df handling missing entries badly
  • add tests

@codecov-io
Copy link

codecov-io commented Feb 11, 2020

Codecov Report

Merging #286 into develop will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #286   +/-   ##
========================================
  Coverage    76.99%   76.99%           
========================================
  Files           22       22           
  Lines         1804     1804           
  Branches       390      390           
========================================
  Hits          1389     1389           
  Misses         319      319           
  Partials        96       96
Impacted Files Coverage Δ
petab/lint.py 74.43% <ø> (ø) ⬆️
petab/core.py 84.87% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b37be78...a5f0052. Read the comment docs.

@yannikschaelte yannikschaelte self-assigned this Feb 11, 2020
petab/core.py Outdated Show resolved Hide resolved
petab/lint.py Outdated Show resolved Hide resolved
tests/test_lint.py Outdated Show resolved Hide resolved
@yannikschaelte yannikschaelte merged commit f302cab into develop Feb 11, 2020
@yannikschaelte yannikschaelte deleted the fix_prior_scales branch February 11, 2020 16:56
@yannikschaelte yannikschaelte mentioned this pull request Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants