Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify condition table column names occur as model parameters (Closes… #151

Merged
merged 2 commits into from
Nov 29, 2019
Merged

Verify condition table column names occur as model parameters (Closes… #151

merged 2 commits into from
Nov 29, 2019

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Nov 28, 2019

… #150)

@codecov-io
Copy link

codecov-io commented Nov 28, 2019 •
edited
Loading

Codecov Report

Merging #151 into develop will decrease coverage by 0.24%.
The diff coverage is 16.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #151      +/-   ##
===========================================
- Coverage    72.13%   71.88%   -0.25%     
===========================================
  Files           12       12              
  Lines         1152     1156       +4     
  Branches       262      265       +3     
===========================================
  Hits           831      831              
- Misses         273      277       +4     
  Partials        48       48
Impacted Files Coverage Δ
petab/lint.py 52.17% <16.66%> (-1.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82ff3dc...a5af9be. Read the comment docs.

yannikschaelte
yannikschaelte approved these changes Nov 28, 2019
View reviewed changes
Copy link
Member

@yannikschaelte yannikschaelte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense

@dweindl dweindl merged commit 12f75a1 into develop Nov 29, 2019
@dweindl dweindl deleted the fix_150_validate_condition_params branch November 29, 2019 00:33
dweindl added a commit that referenced this pull request Nov 29, 2019
@dweindl
Fixup #151: ignore conditionName column
58c0dfd
dweindl added a commit that referenced this pull request Nov 29, 2019
@dweindl
Fixup #151: ignore conditionName column (#153)
90d8545
This was referenced Dec 4, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yannikschaelte yannikschaelte yannikschaelte approved these changes

@elbaraim elbaraim Awaiting requested review from elbaraim

@MerktSimon MerktSimon Awaiting requested review from MerktSimon

@erikadudki erikadudki Awaiting requested review from erikadudki

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dweindl @codecov-io @yannikschaelte