Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataFrame parameter requires the columns {'nominalValue'}. #303

Closed
FFroehlich opened this issue Feb 18, 2020 · 1 comment · Fixed by #357
Closed

DataFrame parameter requires the columns {'nominalValue'}. #303

FFroehlich opened this issue Feb 18, 2020 · 1 comment · Fixed by #357
Assignees
@dweindl
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@FFroehlich
Copy link
Collaborator

FFroehlich commented Feb 18, 2020 •
edited
Loading

If I specify estimate==1 for all parameters, why do I still have to provide the nominalValue column, given that its optional (see https://petab.readthedocs.io/en/stable/documentation_data_format.html#parameter-table). What should I pass if I don't want to specify any value? np.nan, ''?
@dweindl dweindl added the good first issue Good for newcomers label Feb 18, 2020
@dweindl
Copy link
Member

dweindl commented Feb 18, 2020

Sounds like a bug to me.

@dweindl dweindl added the bug Something isn't working label Feb 18, 2020
@dweindl dweindl added this to the v0.1.3 milestone Feb 28, 2020
@dweindl dweindl self-assigned this Feb 28, 2020
dweindl added a commit that referenced this issue Feb 28, 2020
@dweindl
Fix validator: nominalValue is optional unless estimated!=1 anywhere (F…
9efc3de 
…ixes #303)
dweindl added a commit that referenced this issue Feb 28, 2020
@dweindl
Fix validator: nominalValue is optional unless estimated!=1 anywhere (F…
9448e39 
…ixes #303)
@dweindl dweindl mentioned this issue Feb 28, 2020
Merged
dweindl added a commit that referenced this issue Feb 28, 2020
@dweindl
Merge pull request #357 from PEtab-dev/release_0.1.3
7b9d189 
Release 0.1.3

File format:

* Updated documentation
* Observables table in YAML file now mandatory in schema (was implicitly 
  mandatory before, as observable table was required already)

Library:
* petablint:
  * Fix: allow specifying observables file via CLI (Closes #302)
  * Fix: nominalValue is optional unless estimated!=1 anywhere (Fixes #303)
  * Fix: handle undefined observables more gracefully (Closes #300) (#351)
* Parameter mapping: 
  * Fix / refactor parameter mapping (breaking change) (#344)
    (now performing parameter value and scale mapping together)
  * check optional measurement cols in mapping (#350)
* allow calculating llhs (#349), chi2 values (#348) and residuals (#345)
* Visualization
  * Basic Scatterplots & lot of bar plot fixes (#270)
  * Fix incorrect length of bool `bool_preequ` when subsetting with ind_meas 
    (Closes #322)
* make libcombine optional (#338)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dweindl dweindl

Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Release 0.1.3 PEtab-dev/PEtab
2 participants
@FFroehlich @dweindl