test_neighbours: fix warnings in static analyzer.

dlbeer · dlbeer · commit 8d0eb68255c2 · 2013-02-02T18:07:22.000+13:00
Coverity complains that a negative value of best_v might be passed to record_qr_grid(). Fix supplied by Harald Eilertsen (http://github.com/snake66/).
diff --git a/lib/identify.c b/lib/identify.c
@@ -1011,7 +1011,7 @@ static void test_neighbours(struct quirc *q, int i,
 			}
 		}
 
-	if (best_h < 0)
+	if (best_h < 0 || best_v < 0)
 		return;
 
 	record_qr_grid(q, best_h, i, best_v);

Original file line number	Diff line number	Diff line change
`@@ -1011,7 +1011,7 @@ static void test_neighbours(struct quirc *q, int i,`
`1011`	`1011`	`}`
`1012`	`1012`	`}`
`1013`	`1013`
`1014`		`- if (best_h < 0)`
	`1014`	`+ if (best_h < 0 \|\| best_v < 0)`
`1015`	`1015`	`return;`
`1016`	`1016`
`1017`	`1017`	`record_qr_grid(q, best_h, i, best_v);`