Merge pull request #269 from Oxid15/artifact_rm_confirmation

Add simple confirmation before removing artifacts

Author: Oxid15

cascade/cli/artifact.py

@@ -35,6 +35,7 @@ class RemoveResult:
 
     FAIL - something went wrong when removing a file
     """
+
     status: Literal["OKAY", "MISS", "FAIL"]
     path: Optional[str] = None
     traceback: Optional[str] = None
@@ -101,11 +102,16 @@ def artifact(ctx):
 
 
 @artifact.command("rm")
+@click.option("-y", is_flag=True, expose_value=True, help="Confirm")
 @click.pass_context
-def artifact_rm(ctx):
+def artifact_rm(ctx, y):
     """
     Remove artifacts from the whole container recursively
     """
+
+    if not y:
+        click.confirm("Confirm?", abort=True)
+
     results_list = []
     flat_results = []
     if ctx.obj["type"] == "model":

cascade/tests/cli/test_artifact.py

@@ -42,16 +42,12 @@ def test_rm_model(tmp_path_str):
         model.save_artifact(artifact_path)
         MetaHandler.write_dir(td, model.get_meta())
 
-        assert os.path.exists(
-            os.path.join(td, "artifacts", "artifact.txt")
-        )
+        assert os.path.exists(os.path.join(td, "artifacts", "artifact.txt"))
 
-        result = runner.invoke(cli, args=["artifact", "rm"])
+        result = runner.invoke(cli, args=["artifact", "rm", "-y"])
         assert result.exit_code == 0
 
-        assert not os.path.exists(
-            os.path.join(td, "artifacts", "artifact.txt")
-        )
+        assert not os.path.exists(os.path.join(td, "artifacts", "artifact.txt"))
 
 
 def test_rm_model_error(tmp_path_str):
@@ -63,18 +59,14 @@ def test_rm_model_error(tmp_path_str):
         model.save_artifact(artifact_path)
         MetaHandler.write_dir(td, model.get_meta())
 
-        assert os.path.exists(
-            os.path.join(td, "artifacts", "artifact.txt")
-        )
+        assert os.path.exists(os.path.join(td, "artifacts", "artifact.txt"))
 
-        with patch('os.remove') as mocked_remove:
+        with patch("os.remove") as mocked_remove:
             mocked_remove.side_effect = OSError()
 
-            result = runner.invoke(cli, args=["artifact", "rm"])
+            result = runner.invoke(cli, args=["artifact", "rm", "-y"])
             assert result.exit_code == 0
 
             mocked_remove.assert_called_once_with(os.path.join(td, "artifacts", "artifact.txt"))
 
-            assert os.path.exists(
-                os.path.join(td, "artifacts", "artifact.txt")
-            )
+            assert os.path.exists(os.path.join(td, "artifacts", "artifact.txt"))