Fix dask compatibility issues in _decimal_year
#18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Author
|
Oh sorry, this is actually going to end up with the same problem...since in the case of standard datetimes |
aulemahal
approved these changes
Sep 9, 2024
Collaborator
aulemahal
left a comment
aulemahal
left a comment
There was a problem hiding this comment.
Thanks a lot @spencerkclark !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@aulemahal I think this should resolve the dask compatibility issues in
_decimal_year. I'm not sure how to make your original approach work for versions of NumPy < 2—it seems like it should if it weren't for what looks like an old upstream issue—but this at least gets the rollback approach working.