DOCtor-RST against 3.4 #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
force-pushed
the
doctor-rst
branch
11 times, most recently
from
8389049 to
45409d0
Compare
OskarStark
force-pushed
the
doctor-rst
branch
3 times, most recently
from
8f8b30b to
8850ca8
Compare
OskarStark
force-pushed
the
doctor-rst
branch
2 times, most recently
from
45a18bd to
607d450
Compare
OskarStark
force-pushed
the
doctor-rst
branch
3 times, most recently
from
1b75db5 to
bd71828
Compare
OskarStark
pushed a commit
that referenced
this pull request
Mar 26, 2022
…ng a Service Locator" section (jbieliauskas) This PR was merged into the 4.4 branch. Discussion ---------- [DependencyInjection] Fix YAML example in "Defining a Service Locator" section Using this example in `v5.3.13` gives this error: ``` Symfony\Component\DependencyInjection\Definition::setArguments(): Argument #1 ($arguments) must be of type array, Symfony\Component\DependencyInjection\Argument\ServiceLocatorArgument given, called in /project/vendor/symfony/dependency-injection/Loader/YamlFileLoader.php on line 527 ``` I assume this is because `!service_locator` is the first constructor argument but it's passed as an array of constructor arguments, in which case the example is not right. <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/releases for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `6.x` for features of unreleased versions). --> Commits ------- bd8b262 Fix YAML example in "Defining a Service Locator" section
OskarStark
pushed a commit
that referenced
this pull request
Jul 6, 2022
hello, when running the example as it is, a deprecation message is shown (i'm on PHP 8.1.6). the deprecation message says that ``trim(): Passing null to parameter #1 ($string) of type string is deprecated``. what if we add a normalizer that returns an empty string when the entered value is `null` otherwise returns the user's intial input. with this suggestion, the example works great
OskarStark
pushed a commit
that referenced
this pull request
Jul 6, 2022
…1989) This PR was submitted for the 6.0 branch but it was merged into the 4.4 branch instead. Discussion ---------- [Console] Update questionhelper.rst hello, when running the example as it is, a deprecation message is shown (i'm on PHP 8.1.6). the deprecation message says that ``trim(): Passing null to parameter #1 ($string) of type string is deprecated``. what if we add a normalizer that returns an empty string when the entered value is `null` otherwise returns the user's intial input. with this suggestion, the example works great <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/releases for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `6.x` for features of unreleased versions). --> Commits ------- bf9e245 Update questionhelper.rst
OskarStark
pushed a commit
that referenced
this pull request
Oct 24, 2023
- parameter $year is typed with integer. date function returns string. Code works but casting to the right type feels better. - added missing import to fix TypeError "Argument #1 ($request) must be of type Request"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.