Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues when making selections #39

Open
admanct opened this issue Jan 19, 2019 · 5 comments
Open

Issues when making selections #39

admanct opened this issue Jan 19, 2019 · 5 comments
Labels
area/application Task related to orcpub application itself bug Something isn't working

Comments

@admanct
Copy link

admanct commented Jan 19, 2019

When having to make a subclass that gets to choose from a list of options at various levels only the first number is available. For example if you picked 1 selection from a list of class abilities at level 3, then 2 more at level 5 the feature as it currently is will only allow you to select 1 option and not the 3 total options that should be allowed. I do not believe this bug is present within the class feature, only the subclass feature, though I am unsure of this

@codeGlaze
Copy link

Selections do not currently properly unlock at the appropriate levels. It is not a problem limited to subclasses. 👍

@codeGlaze codeGlaze added bug Something isn't working area/application Task related to orcpub application itself labels Jan 19, 2019
@JaxeHall
Copy link

I believe there is also a graphical bug associated with this issue. When leveling up a character that requires selecting additional selections, the class/level tab gets a red notification badge indicating additional changes to be made, presumably from needing to select additional selections, however this is inconsistent as all areas in the class/level tab have a green notification badge suggesting no changes are necessary.

@snorrekim
Copy link

snorrekim commented Oct 15, 2019

I've mostly worked out what's happening:

The bug seems to be that it only expects 1 row of each selection.

  • In class editor it will only show the first selection of a type that meets level requirements.
    • Therefore, the higher levels selections will be unchoosable (this can be worked around)
  • The counter in the "class / level" tab however, will count all the selections, at the same time. That is to say, if you have 3 selections that have the same type, and you pick one, it will count that as 3 chosen.
    • Therefore, it will count more missing than you can choose, and it will count the reverse "too many selected" for every selection row that have less. (It's easier to understand in the workaround/example below)

Workaround (only for subclasses)

A workaround is to add the expanding selections in reverse order and to add the total amounts.

Don't do this:

Selection Level Amount
Cantrips 2 3
Cantrips 5 1
Cantrips 7 1
Cantrips 10 1

No matter what level above 2 you are, it will stop at the first row and ignore the rest.

Instead, do this:

Selection Level (reverse order) Amount (total on each level)
Cantrips 10 6
Cantrips 7 5
Cantrips 5 4
Cantrips 2 3

This will, at least, let you select the correct amount at each level. But annoyingly, It will still show the wrong number in the "class/level" tab.

Why it shows the wrong number in the "class / level" tab

The number in the "class/level" tab goes haywire because it counts both "need to choose" and "too many chosen", and, as I mentioned, it counts all the select at the same time.

First table at level 7

  • The tab first shows "5"
    • you are missing [3-1-1].
  • The first pick lowers it to "2"
    • you are missing [2-0-0]
    • (1 selector say you are missing two)
  • The second pick increases it to "3"
    • you are missing [1-0-0], and have too many [0-1-1]
    • (1 selector say you are missing one, 2 selectors say you have 1 too many)
  • The third pick increases it to "4"
    • you have too many [0-2-2]
    • (2 selectors say you have two too many)

Second table at level 7

So, using the second table above, I can now add 5 cantrips at level 7. The number on top starts as "12" (5+4+3). And after 5 picks it shows "3" (the level 5 row complains that I have 1 too many, and the level 2 row complains that I have 2 too many).

@DivertedCircle
Copy link

Creating Selections in reverse order as you've pointed out works in the Subclass Builder however it appears to break when doing so in the Class Builder.

@DivertedCircle
Copy link

I've noticed an additional graphical issue related to Selections. If you have more than 10 Selections listed in a subclass, only the first 10 display properly in the character builder. Going past 10 causes the character builder to incorrectly show the maximum number of selections already made, even though the Class / Level tab shows selections still needed, as does the AL Illegal drop down.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/application Task related to orcpub application itself bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants