Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animation Timeline UI Improvements #769

Merged
merged 21 commits into from
Oct 21, 2022

Conversation

mrtripie
Copy link
Contributor

@mrtripie mrtripie commented Oct 18, 2022

  • Fixed link cel indicator color having no saturation

  • Fixed animation tags position

  • Restructured AnimationTimeline scene a bit

    • Node tree is organized closer to the way it looks like it should be (IE: The Layer Buttons and Opacity slider are kept inside the same VBoxContainer, all inside the panel container)
    • Renamed things for consistency:
      • LayersContainer/layers_container -> LayerVBox/layer_vbox
      • FrameIDs/frame_ids -> FrameHBox/frame_hbox
      • FramesContainer/frames_container -> CelVBox/cel_vbox
      • Variables in code of CelVbox's children -> cel_hbox
  • Improved scrolling

    • Horizontal scrolling is only for frames. Added a FrameScrollContainer script for that.
    • The Animation buttons are now in their own scrollcontianer (sharing the hidden scrollbar theme of the tag scrollbar)
  • Automatic minimum size for timeline

  • Resizable Layer Buttons

    • Made the default size for Layer Buttons a little smaller
    • Layer and cel size is saved between sessions
  • Playing animations or adding frames automatically ensures the frame button is visible

  • Combined _on_AddLayer_pressed and _on_AddGroup_pressed into 1 add_layer method

  • Removed some hacks

  • Added some hacks

    • Ensuring the frame is visible when adding frames requires 3 call_deferred calls chained together...

@mrtripie mrtripie changed the title Animation Timeline UI Tweaks Animation Timeline UI Improvements Oct 19, 2022
@mrtripie mrtripie marked this pull request as ready for review October 19, 2022 20:15
Copy link
Member

@OverloadedOrama OverloadedOrama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks amazing, thank you!

@OverloadedOrama OverloadedOrama merged commit e8281bf into Orama-Interactive:master Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants