fix: remove unneeded "source" key from package.json exports #27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
The
"source"
field in the package.json"exports"
is causing issues with some repos. The purpose of this field is so that tools such as Jest and Storybook can resolve references to local packages without those packages needing to be built first. However, in our entire repository there are currently no references to@optum/react-hooks
which would need to be resolved locally, and the existence of this"source"
custom condition is conflicting with other repos that also use"source"
.If we do at some point require this functionality (for example, if we turn this repository into a monorepo with multiple packages) then we should use a more unique name other than "source" to avoid conflicts with other repos that might be using "source" as a custom export condition.
Types of changes
What types of changes does your code introduce?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.