Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unneeded "source" key from package.json exports #27

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

nthurow
Copy link
Contributor

@nthurow nthurow commented Mar 26, 2024

Proposed changes

The "source" field in the package.json "exports" is causing issues with some repos. The purpose of this field is so that tools such as Jest and Storybook can resolve references to local packages without those packages needing to be built first. However, in our entire repository there are currently no references to @optum/react-hooks which would need to be resolved locally, and the existence of this "source" custom condition is conflicting with other repos that also use "source".

If we do at some point require this functionality (for example, if we turn this repository into a monorepo with multiple packages) then we should use a more unique name other than "source" to avoid conflicts with other repos that might be using "source" as a custom export condition.

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

@NielsJPeschel NielsJPeschel merged commit 9e5fa01 into main Mar 26, 2024
4 checks passed
@NielsJPeschel NielsJPeschel deleted the fix_exports_keys branch March 26, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants