Skip to content

Conversation

@shubydo
Copy link
Collaborator

@shubydo shubydo commented May 18, 2022

Proposed changes

Fix issues in CICD pipeline causing builds and status checks to fail, blocking new features from being merged.

  • Upgrade Ubuntu agent version to 20.04

    • 16.04 has been decommissioned in October 2021. More info here.
  • Fix errors in pipeline when fetching Go dependencies for current linting tools

    • Go 1.15 and 1.16 are deprecated, causing newer versions of linting tools to fail when installing. NOTE: Project has been upgraded to1.17 as part of resolving these errors.
  • Fix conflict error when deploying/updating application code preventing publishing new version of Lambda function

    • Example of error: An error occurred (ResourceConflictException) when calling the PublishVersion operation: The operation cannot be performed at this time. An update is in progress for resource: arn:aws:lambda:....
  • Fix issue in PR pipeline where newly leased ephemeral AWS account is not being used when setting up infra for testing. (Current understanding of problem here)

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (changes to code, which do not change application behavior)

Checklist

  • I have filled out this PR template
  • I have read the CONTRIBUTING doc
  • I have added automated tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (README.md, inline comments, etc.)
  • I have updated the CHANGELOG.md under a ## next release, with a short summary of my changes

Relevant Links

Further comments

@CLAassistant
Copy link

CLAassistant commented May 18, 2022

CLA assistant check
All committers have signed the CLA.

@shubydo shubydo marked this pull request as draft May 18, 2022 19:29
@shubydo shubydo self-assigned this May 18, 2022
@shubydo shubydo changed the title Upgrade Ubuntu version on Azure DevOps agent Fix CICD Pipeline: Upgrade Ubuntu version on Azure DevOps agent, Go dependency errors, and more May 19, 2022
@shubydo shubydo force-pushed the upgrade-agent-version branch from 637a893 to 020b968 Compare May 19, 2022 18:35
@shubydo shubydo force-pushed the upgrade-agent-version branch from 020b968 to 125a174 Compare May 26, 2022 06:21
@eric-w-hart
Copy link

@shubydo Can you complete the Checklist segement?
@nathanagood could you do a review for this PR?
Thanks,

@eric-w-hart eric-w-hart requested a review from nathanagood May 27, 2022 12:05
@shubydo shubydo requested a review from eric-w-hart May 27, 2022 13:57
@shubydo shubydo marked this pull request as ready for review May 27, 2022 13:58
@shubydo
Copy link
Collaborator Author

shubydo commented May 27, 2022

@eric-w-hart @nathanagood pipeline is having some errors when trying to install the linting tools. Still needs to be fixed before the checks will pass

@eric-w-hart
Copy link

@eric-w-hart @nathanagood pipeline is having some errors when trying to install the linting tools. Still needs to be fixed before the checks will pass

golang lint is throwing an error and Terraform is out of date.
Researching both.

@shubydo shubydo force-pushed the upgrade-agent-version branch from f1da689 to 35a8789 Compare July 1, 2022 22:25
@shubydo
Copy link
Collaborator Author

shubydo commented Jul 1, 2022

@eric-w-hart @nathanagood pipeline is having some errors when trying to install the linting tools. Still needs to be fixed before the checks will pass

golang lint is throwing an error and Terraform is out of date. Researching both.

@eric-w-hart @nathanagood This is now fixed. It's now pending deployment here. Needs an approval.

Let's get the pipeline passing as part of this PR and do the terraform upgrade in subsequent PRs. Once the pipeline is fixed this will help unblock the pending PRs.

@shubydo shubydo mentioned this pull request Jul 1, 2022
9 tasks
@shubydo shubydo added the bug Something isn't working label Jul 1, 2022
@shubydo shubydo mentioned this pull request Jul 1, 2022
9 tasks
eric-w-hart
eric-w-hart previously approved these changes Jul 5, 2022
@shubydo shubydo force-pushed the upgrade-agent-version branch from 4258c3e to 9f81f15 Compare July 7, 2022 21:41
@jrsholly jrsholly force-pushed the upgrade-agent-version branch from 846acf7 to 963afef Compare December 6, 2022 19:15
@jrsholly jrsholly self-requested a review December 8, 2022 14:16
@shubydo shubydo merged commit 25a4530 into master Dec 8, 2022
@shubydo shubydo deleted the upgrade-agent-version branch December 8, 2022 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants