Skip to content

Remove dependency to coroutine core lib #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 8, 2025
Merged

Remove dependency to coroutine core lib #254

merged 1 commit into from
Feb 8, 2025

Conversation

OptimumCode
Copy link
Owner

Resolves #239

@OptimumCode OptimumCode added tests Tests enhancements internal Changes in internal part of the library maintenance maintenance task labels Feb 8, 2025
@OptimumCode OptimumCode enabled auto-merge (squash) February 8, 2025 16:05
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'KMP JSON schema validator'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.50.

Benchmark suite Current: 6e325b4 Previous: 027c709 Ratio
macosArm64.CommonAvgTimeBench.validateBasic ( {"objectPath":"openapi.json","schemaPath":"openapi_schema.json"} ) 2202.836399625468 us/op 1068.875324759872 us/op 2.06
macosArm64.CommonAvgTimeBench.validateBasic ( {"objectPath":"openapi-invalid.json","schemaPath":"openapi_schema.json"} ) 2513.962829618768 us/op 1165.8310817264573 us/op 2.16
macosArm64.CommonAvgTimeBench.validateDetailed ( {"objectPath":"openapi.json","schemaPath":"openapi_schema.json"} ) 5069.17633877551 us/op 2586.5718406169667 us/op 1.96
macosArm64.CommonAvgTimeBench.validateDetailed ( {"objectPath":"openapi-invalid.json","schemaPath":"openapi_schema.json"} ) 5220.567223780487 us/op 2848.9320232294617 us/op 1.83
macosArm64.CommonAvgTimeBench.validateFlag ( {"objectPath":"openapi.json","schemaPath":"openapi_schema.json"} ) 1464.530431076179 us/op 783.2643267234702 us/op 1.87
macosArm64.CommonAvgTimeBench.validateFlag ( {"objectPath":"openapi-invalid.json","schemaPath":"openapi_schema.json"} ) 1.0920661629596877 us/op 0.5302771226337653 us/op 2.06
macosArm64.CommonAvgTimeBench.validateVerbose ( {"objectPath":"openapi.json","schemaPath":"openapi_schema.json"} ) 10320.96500967742 us/op 5342.861103409092 us/op 1.93
macosArm64.CommonAvgTimeBench.validateVerbose ( {"objectPath":"openapi-invalid.json","schemaPath":"openapi_schema.json"} ) 9786.269552136753 us/op 5360.938910582011 us/op 1.83
macosArm64.CommonAvgTimeBench.validate ( {"objectPath":"openapi.json","schemaPath":"openapi_schema.json"} ) 2071.221717255717 us/op 1027.8737907692307 us/op 2.02
macosArm64.CommonAvgTimeBench.validate ( {"objectPath":"openapi-invalid.json","schemaPath":"openapi_schema.json"} ) 2060.1514991554054 us/op 1061.9133381395347 us/op 1.94

This comment was automatically generated by workflow using github-action-benchmark.

CC: @OptimumCode

@OptimumCode OptimumCode merged commit 54cfb38 into main Feb 8, 2025
20 checks passed
@OptimumCode OptimumCode deleted the support/239 branch February 8, 2025 16:24
Copy link

codecov bot commented Feb 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.69%. Comparing base (a03e115) to head (6e325b4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #254   +/-   ##
=======================================
  Coverage   90.69%   90.69%           
=======================================
  Files         133      133           
  Lines        3977     3977           
  Branches     1058     1058           
=======================================
  Hits         3607     3607           
  Misses         76       76           
  Partials      294      294           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Changes in internal part of the library maintenance maintenance task tests Tests enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support: remove test dependency to coroutines
1 participant