Remove shouldNotThrowAny from test where the returned value is used later

Author: OptimumCode

json-schema-validator/src/commonTest/kotlin/io/github/optimumcode/json/schema/base/JsonSchemaLoaderTest.kt

@@ -13,7 +13,6 @@ import io.github.optimumcode.json.schema.ValidationError
 import io.github.optimumcode.json.schema.model.AbstractElement
 import io.github.optimumcode.json.schema.model.PrimitiveElement
 import io.kotest.assertions.assertSoftly
-import io.kotest.assertions.throwables.shouldNotThrowAny
 import io.kotest.assertions.throwables.shouldNotThrowAnyUnit
 import io.kotest.assertions.throwables.shouldThrow
 import io.kotest.assertions.withClue
@@ -315,31 +314,29 @@ class JsonSchemaLoaderTest : FunSpec() {
     // https://github.com/OptimumCode/json-schema-validator/issues/87
     test("BUG_87 relative uri-ref in root \$id causes incorrect reference resolution for root schema") {
       val schema =
-        shouldNotThrowAny {
-          JsonSchemaLoader.create()
-            .register(
-              """
-              {
+        JsonSchemaLoader.create()
+          .register(
+            """
+            {
+              "${'$'}schema": "https://json-schema.org/draft/2020-12/schema",
+              "${'$'}id": "myproject/enums/foo",
+              "type": "integer"
+            }
+            """.trimIndent(),
+          ).fromDefinition(
+            """
+            {
                 "${'$'}schema": "https://json-schema.org/draft/2020-12/schema",
-                "${'$'}id": "myproject/enums/foo",
-                "type": "integer"
-              }
-              """.trimIndent(),
-            ).fromDefinition(
-              """
-              {
-                  "${'$'}schema": "https://json-schema.org/draft/2020-12/schema",
-                  "${'$'}id": "myproject/data/request",
-                  "type": "object",
-                  "properties": {
-                      "foobar": {
-                          "${'$'}ref": "/myproject/enums/foo"
-                      }
-                  }
-              }
-              """.trimIndent(),
-            )
-        }
+                "${'$'}id": "myproject/data/request",
+                "type": "object",
+                "properties": {
+                    "foobar": {
+                        "${'$'}ref": "/myproject/enums/foo"
+                    }
+                }
+            }
+            """.trimIndent(),
+          )
 
       val errors = mutableListOf<ValidationError>()
       val valid =

json-schema-validator/src/commonTest/kotlin/io/github/optimumcode/json/schema/extension/JsonSchemaExtensionTest.kt

@@ -8,7 +8,6 @@ import io.github.optimumcode.json.schema.ValidationError
 import io.github.optimumcode.json.schema.model.AbstractElement
 import io.github.optimumcode.json.schema.model.PrimitiveElement
 import io.kotest.assertions.assertSoftly
-import io.kotest.assertions.throwables.shouldNotThrowAny
 import io.kotest.assertions.throwables.shouldThrow
 import io.kotest.assertions.withClue
 import io.kotest.core.spec.style.FunSpec
@@ -98,23 +97,19 @@ class JsonSchemaExtensionTest : FunSpec() {
 
     test("registers all extensions with varargs") {
       val schema =
-        shouldNotThrowAny {
-          JsonSchemaLoader
-            .create()
-            .withExtensions(SimpleTimeFormatAssertionFactory, SimpleDateFormatAssertionFactory)
-            .fromDefinition(schemaDef)
-        }
+        JsonSchemaLoader
+          .create()
+          .withExtensions(SimpleTimeFormatAssertionFactory, SimpleDateFormatAssertionFactory)
+          .fromDefinition(schemaDef)
       checkValidAndInvalid(schema)
     }
 
     test("registers all extensions with iterable") {
       val schema =
-        shouldNotThrowAny {
-          JsonSchemaLoader
-            .create()
-            .withExtensions(listOf(SimpleTimeFormatAssertionFactory, SimpleDateFormatAssertionFactory))
-            .fromDefinition(schemaDef)
-        }
+        JsonSchemaLoader
+          .create()
+          .withExtensions(listOf(SimpleTimeFormatAssertionFactory, SimpleDateFormatAssertionFactory))
+          .fromDefinition(schemaDef)
       checkValidAndInvalid(schema)
     }
   }

test-suites/src/commonTest/kotlin/io/github/optimumcode/json/schema/suite/AbstractSchemaTestSuite.kt

@@ -8,7 +8,6 @@ import io.github.optimumcode.json.schema.JsonSchema
 import io.github.optimumcode.json.schema.JsonSchemaLoader
 import io.github.optimumcode.json.schema.SchemaOption
 import io.github.optimumcode.json.schema.SchemaType
-import io.kotest.assertions.throwables.shouldNotThrowAny
 import io.kotest.assertions.withClue
 import io.kotest.core.spec.style.FunSpec
 import io.kotest.matchers.shouldBe
@@ -235,12 +234,8 @@ private fun FunSpec.executeFromDirectory(
         test("$testSuiteID at index $testSuiteIndex test $testIndex") {
           withClue(listOf(testSuite.description, testSuite.schema, test.description, test.data)) {
             val schema: JsonSchema =
-              shouldNotThrowAny {
-                schemaLoader.fromJsonElement(testSuite.schema, schemaType)
-              }
-            shouldNotThrowAny {
-              schema.validate(test.data, ErrorCollector.EMPTY)
-            } shouldBe test.valid
+              schemaLoader.fromJsonElement(testSuite.schema, schemaType)
+            schema.validate(test.data, ErrorCollector.EMPTY) shouldBe test.valid
           }
         }
       }