update DVC #369
update DVC #369
Conversation
ebrahimebrahim
left a comment
ebrahimebrahim
left a comment
There was a problem hiding this comment.
Certain users were kept in the database but were removed from users.json. do you want to remove the remaining users, or do you want to expand users.json to sync it back up to what users are available?
Tested in SlicerOpenLIFU and looked over a diff. All looks good except the above comment.
(Unrelated to this PR: I noticed with the 1x400_evt1 that ICP doesn't snap the transducer onto the photoscan very well. It needs a good deal of manual fixing. I wonder why that is happening. Maybe the side walls are competing with the front face in a way that hurts ICP? Need to think about it...)
completing the update of the previous commit
ebrahimebrahim
force-pushed
the
p/update_dvc
branch
from
fd57205 to
a18c5f0
Compare
ebrahimebrahim
left a comment
ebrahimebrahim
left a comment
There was a problem hiding this comment.
Certain users were kept in the database but were removed from
users.json. do you want to remove the remaining users, or do you want to expandusers.jsonto sync it back up to what users are available?
confirmed in meeting that the extra users should be deleted. I have done this and also standardized the formatting (via the script we have in scripts/)
merging
Hygenic update to DVC content. Removed the prior examples and replaced them with the current demo device/protocol
definitions.